On 3/14/2018 9:41 PM, Alexander Duyck wrote: >> } >> > So you missed the writel in e1000_xmit_frame. You should probably get > that one too while you are doing these updates. The wmb() is in > e1000_tx_queue(). > I brought wmb() outside along with the next descriptor assignment to be similar to the rest of the other code. if wmb() and writel() are not visible in the same function, let's not touch the code. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html