Re: [PATCH] rpmsg: glink: Use spinlock in tx path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey Bjorn,

Minor issue with the glink patch.

Thanks,
Chris

On 2/13/2018 11:04 AM, Bjorn Andersson wrote:

[..]
@@ -288,15 +288,14 @@ static int qcom_glink_tx(struct qcom_glink *glink,
  			 const void *data, size_t dlen, bool wait)
  {
  	unsigned int tlen = hlen + dlen;
+	unsigned long flags;
  	int ret;
/* Reject packets that are too big */
  	if (tlen >= glink->tx_pipe->length)
  		return -EINVAL;
- ret = mutex_lock_interruptible(&glink->tx_lock);
-	if (ret)
-		return ret;
+	spin_lock_irqsave(&glink->tx_lock, flags);

qcom_glink_tx will return an uninitialized ret value with removal of mutex_lock_interruptible.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux