On Wed 31 Jan 11:02 PST 2018, Karthik Ramasubramanian wrote: > On 1/19/2018 3:57 PM, Rob Herring wrote: > > On Thu, Jan 18, 2018 at 08:57:45AM -0800, Bjorn Andersson wrote: > > > On Thu 18 Jan 01:13 PST 2018, Rajendra Nayak wrote: [..] > > > > > > > > > > Please use SPDX style license header, i.e. this file should start with: > > > > > > > > > > // SPDX-License-Identifier: GPL-2.0 > > > > > /* > > > > > * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. > > > > > */ > > > > > > > > Looks like Mark Brown commented elsewhere [1] that we should use the C++ > > > > commenting style even for the Linux Foundation copyright? > > > > > > > > [1] https://marc.info/?l=linux-clk&m=151497978626135&w=2 > > > > > > > > > > While I can agree with Mark on the ugliness of the mixed commenting > > > style, this is the style that I found communicated and is what you find > > > in other files. > > > > Well, that's pretty new guidance. Moving target... > > > > Given that Linus said '//' comments are the only thing C++ got right, I > > expect to see more of them. > I believe that in the source file I have to use C++ style comments(as per > this discussion) and in the header file I have to use C-style comments (as > per https://lwn.net/Articles/739183/ for reasons related to tooling). Please > correct me otherwise. I had missed that detail, you're right. Thanks, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
