Re: [PATCH 2/2] drm/msm/adreno: Add A6XX device support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jordan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robclark/msm-next]
[also build test ERROR on next-20180201]
[cannot apply to v4.15]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jordan-Crouse/drm-msm-Add-support-for-Adreno-a6xx/20180201-224050
base:   git://people.freedesktop.org/~robclark/linux msm-next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm64 

All error/warnings (new ones prefixed by >>):

   drivers/gpu/drm/msm/adreno/a6xx_gpu.c: In function 'a6xx_ucode_init':
>> drivers/gpu/drm/msm/adreno/a6xx_gpu.c:301:22: error: implicit declaration of function 'adreno_request_fw_bo'; did you mean 'adreno_request_fw'? [-Werror=implicit-function-declaration]
      a6xx_gpu->sqe_bo = adreno_request_fw_bo(gpu,
                         ^~~~~~~~~~~~~~~~~~~~
                         adreno_request_fw
>> drivers/gpu/drm/msm/adreno/a6xx_gpu.c:301:20: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      a6xx_gpu->sqe_bo = adreno_request_fw_bo(gpu,
                       ^
   cc1: some warnings being treated as errors
--
>> drivers/gpu/drm/msm/adreno/a6xx_gmu.c:17:10: fatal error: soc/qcom/cmd-db.h: No such file or directory
    #include <soc/qcom/cmd-db.h>
             ^~~~~~~~~~~~~~~~~~~
   compilation terminated.

vim +301 drivers/gpu/drm/msm/adreno/a6xx_gpu.c

   294	
   295	static int a6xx_ucode_init(struct msm_gpu *gpu)
   296	{
   297		struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
   298		struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
   299	
   300		if (!a6xx_gpu->sqe_bo) {
 > 301			a6xx_gpu->sqe_bo = adreno_request_fw_bo(gpu,
   302				adreno_gpu->info->pm4fw, &a6xx_gpu->sqe_iova);
   303	
   304			if (IS_ERR(a6xx_gpu->sqe_bo)) {
   305				int ret = PTR_ERR(a6xx_gpu->sqe_bo);
   306	
   307				a6xx_gpu->sqe_bo = NULL;
   308				DRM_DEV_ERROR(&gpu->pdev->dev,
   309					"Could not allocate SQE ucode: %d\n", ret);
   310	
   311				return ret;
   312			}
   313		}
   314	
   315		gpu_write64(gpu, REG_A6XX_CP_SQE_INSTR_BASE_LO,
   316			REG_A6XX_CP_SQE_INSTR_BASE_HI, a6xx_gpu->sqe_iova);
   317	
   318		return 0;
   319	}
   320	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux