On Wed 03 Jan 05:15 PST 2018, Loic PALLARDY wrote: > > -----Original Message----- > > From: linux-remoteproc-owner@xxxxxxxxxxxxxxx [mailto:linux-remoteproc- > > owner@xxxxxxxxxxxxxxx] On Behalf Of Loic PALLARDY > > Sent: Wednesday, January 03, 2018 11:27 AM > > To: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>; Ohad Ben-Cohen > > <ohad@xxxxxxxxxx> > > Cc: linux-remoteproc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- > > arm-msm@xxxxxxxxxxxxxxx; linux-soc@xxxxxxxxxxxxxxx; Suman Anna <s- > > anna@xxxxxx>; Avaneesh Kumar Dwivedi <akdwived@xxxxxxxxxxxxxx> > > Subject: RE: [PATCH v2 2/4] remoteproc: Rename "load_rsc_table" to > > "parse_fw" > > > -----Original Message----- > > > From: linux-remoteproc-owner@xxxxxxxxxxxxxxx [mailto:linux- > > remoteproc- > > > owner@xxxxxxxxxxxxxxx] On Behalf Of Bjorn Andersson [..] > > > - /* load resource table */ > > > - ret = rproc_load_rsc_table(rproc, fw); > > > + /* parse firmware resources */ > > > + ret = rproc_parse_fw(rproc, fw); > > Hi Bjorn, > > > > I think it will be good to keep resource (aka rsc) in function name. only > > "parse_fw" is not enough explicit and we don't know why rproc should parse > > firmware. > > > > Regards, > > Loic > Forgot my previous remark, better understanding thanks to the rest of > the series. > Anyway, will be nice to have a comment here as it is not only parsing > the firmware, you collect some information like copy of the resource > table, list of elf segment to dump... > I think it is important to be clear about resource table management as > it is a key element of the remoteproc core, where it is loaded, where > it is copied back in memory... I didn't manage to come up with a better name, but adding a comment to capture this makes a lot of sense. I will respin this patch! Thanks for reviewing this! Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
