On Tue, 2017-12-12 at 14:17 -0600, Timur Tabi wrote:
> On 12/12/2017 04:05 AM, Andy Shevchenko wrote:
> > > +static const struct acpi_device_id qdf2xxx_acpi_ids[] = {
> > > + {"QCOM8001", QDF2XXX_V1},
> > > + {"QCOM8002", QDF2XXX_V2},
> > > + {},
> > > +};
> > > +MODULE_DEVICE_TABLE(acpi, qdf2xxx_acpi_ids);
> > >
> > > + const struct acpi_device_id *id =
> > > + acpi_match_device(qdf2xxx_acpi_ids, &pdev->dev);
> >
> > JFYI: there is no need to move IDs like this.
> > Use members of struct device_driver wisely.
>
> I have to move it, otherwise I get:
>
> drivers/pinctrl/qcom/pinctrl-qdf2xxx.c:49:21: error:
> 'qdf2xxx_acpi_ids'
> undeclared (first use in this function); did you mean
> 'qdf2xxx_pinctrl'?
>
> I reference the structure in qdf2xxx_pinctrl_probe().
Please, read my comment again. The key part of the phrase:
"Use members of struct device_driver"
So, do not move the IDs. There are examples in the kernel how to access
it.
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
