Hi Philippe, On 12/8/2017 3:53 PM, Philippe Ombredanne wrote: > Sricharan, Stephen, > > On Fri, Dec 8, 2017 at 10:29 AM, Sricharan R <sricharan@xxxxxxxxxxxxxx> wrote: >> From: Stephen Boyd <sboyd@xxxxxxxxxxxxxx> >> >> The Krait CPU clocks are made up of a primary mux and secondary >> mux for each CPU and the L2, controlled via cp15 accessors. For >> Kraits within KPSSv1 each secondary mux accepts a different aux >> source, but on KPSSv2 each secondary mux accepts the same aux >> source. >> >> Cc: <devicetree@xxxxxxxxxxxxxxx> >> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx> > [] >> --- /dev/null >> +++ b/drivers/clk/qcom/krait-cc.c >> @@ -0,0 +1,350 @@ >> +/* Copyright (c) 2013-2015, The Linux Foundation. All rights reserved. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 and >> + * only version 2 as published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + */ > > Have you considered using the new SPDX ids? Something like this: > > // SPDX-License-Identifier: GPL-2.0 > // Copyright (c) 2013-2015, The Linux Foundation. All rights reserved. > > Beside being simpler and increasing the code to comment ratio by > deleting 9 lines of boilerplate, this will also save a few trees over > the long term each time that I print the source code of the kernel ;) > (do not worry, I am NOT as insane as to really print the kernel > sources, but someone more insane than me may well do it) > > You may wonder about the C++ // comment style I used here... Please > see Linus posts on the topic as well as Thomas doc patches overall for > instructions on using the SPDX ids. > > And if you were to do this for your past, present and future > contributions (eventually these of your group), I would be quite > grateful. > > Thank you for your kind consideration > Ha ok. will change it to use this one. Infact saw this feedback on other patches, but missed updating to it while sending. Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
