On 12/6/2017 11:41 AM, Rafael J. Wysocki wrote: > On Wed, Dec 6, 2017 at 5:11 PM, Sinan Kaya <okaya@xxxxxxxxxxxxxx> wrote: >> On 12/6/2017 9:57 AM, Sinan Kaya wrote: >>>> Yes, it should, so I'm not sure why you need the list in the first place. >>>> >>>> Also it looks like something along the lines of devres_release_all() >>>> should be sufficient. >>> Good suggestion, let me test this. >>> >> >> I tried to pull the code into GED but the API is not public. I also looked >> at how it is used. I was afraid to mess up with the internals of base.c by >> calling devres_release_all() externally first and by the driver framework >> next. I moved away from this approach. > > Are you sure it is called by the core in the shutdown path? Sorry, I was thinking about a general case not the shutdown path. If we open this API and have device drivers call it from arbitrary places; then we could be opening a new can of worms that show up during device driver removal. If you feel confident (I'm not), I can pursue this approach too. > >> I just fixed the function rename and changed the dev_info() to dev_dbg(). > > And why do you need the list? > > ged_shutdown() will be called for every device for which ged_probe() > has been called. The problem I had here is that =the last argument is the context pointer when I call devm_free_irq(). If I don't pass the same context I used during IRQ registration, then the IRQ free API fails. That's why, I needed to keep the event pointer around until the IRQ free is called. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
