Re: [PATCH 3/3] clk: qcom: mmcc-msm8996: leave all mmagic gdscs and clocks always enabled

[Archit Taneja <architt@xxxxxxxxxxxxxx>]

On 10/12/2017 12:28 PM, Rajendra Nayak wrote:
> There's no bus infrastructure today to handle all the mmagic bus
> clocks and GDSCs needed by all the multimedia blocks in msm8996, like
> mdss, video, camera and gpu. Mark all these clocks with a CLK_IS_CRITICAL
> and GDSCs with a ALWAYS_ON flag for now so they are left always enabled.
> This patch should be reverted at some point when we do have a bus driver
> to manage these clocks and GDSCs.

The mmagic_bimc_gdsc is needed by display too on 8x96. If I add the new
ALWAYS_ON flag to it, display starts working okay. With that change:

Tested-by: Archit Taneja <architt@xxxxxxxxxxxxxx>

Thanks,
Archit

> Signed-off-by: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx>
> ---
>   drivers/clk/qcom/mmcc-msm8996.c | 22 +++++++++++-----------
>   1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/clk/qcom/mmcc-msm8996.c b/drivers/clk/qcom/mmcc-msm8996.c
> index 352394d..3ba37f3 100644
> --- a/drivers/clk/qcom/mmcc-msm8996.c
> +++ b/drivers/clk/qcom/mmcc-msm8996.c
> @@ -1229,7 +1229,7 @@ enum {
>   			.name = "mmss_mmagic_ahb_clk",
>   			.parent_names = (const char *[]){ "ahb_clk_src" },
>   			.num_parents = 1,
> -			.flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED,
> +			.flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL,
>   			.ops = &clk_branch2_ops,
>   		},
>   	},
> @@ -1244,7 +1244,7 @@ enum {
>   			.name = "mmss_mmagic_cfg_ahb_clk",
>   			.parent_names = (const char *[]){ "ahb_clk_src" },
>   			.num_parents = 1,
> -			.flags = CLK_SET_RATE_PARENT,
> +			.flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL,
>   			.ops = &clk_branch2_ops,
>   		},
>   	},
> @@ -1303,7 +1303,7 @@ enum {
>   			.name = "mmagic_camss_axi_clk",
>   			.parent_names = (const char *[]){ "axi_clk_src" },
>   			.num_parents = 1,
> -			.flags = CLK_SET_RATE_PARENT,
> +			.flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL,
>   			.ops = &clk_branch2_ops,
>   		},
>   	},
> @@ -1318,7 +1318,7 @@ enum {
>   			.name = "mmagic_camss_noc_cfg_ahb_clk",
>   			.parent_names = (const char *[]){ "gcc_mmss_noc_cfg_ahb_clk" },
>   			.num_parents = 1,
> -			.flags = CLK_SET_RATE_PARENT,
> +			.flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL,
>   			.ops = &clk_branch2_ops,
>   		},
>   	},
> @@ -1423,7 +1423,7 @@ enum {
>   			.name = "mmagic_mdss_axi_clk",
>   			.parent_names = (const char *[]){ "axi_clk_src" },
>   			.num_parents = 1,
> -			.flags = CLK_SET_RATE_PARENT,
> +			.flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL,
>   			.ops = &clk_branch2_ops,
>   		},
>   	},
> @@ -1438,7 +1438,7 @@ enum {
>   			.name = "mmagic_mdss_noc_cfg_ahb_clk",
>   			.parent_names = (const char *[]){ "gcc_mmss_noc_cfg_ahb_clk" },
>   			.num_parents = 1,
> -			.flags = CLK_SET_RATE_PARENT,
> +			.flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL,
>   			.ops = &clk_branch2_ops,
>   		},
>   	},
> @@ -1513,7 +1513,7 @@ enum {
>   			.name = "mmagic_video_axi_clk",
>   			.parent_names = (const char *[]){ "axi_clk_src" },
>   			.num_parents = 1,
> -			.flags = CLK_SET_RATE_PARENT,
> +			.flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL,
>   			.ops = &clk_branch2_ops,
>   		},
>   	},
> @@ -1528,7 +1528,7 @@ enum {
>   			.name = "mmagic_video_noc_cfg_ahb_clk",
>   			.parent_names = (const char *[]){ "gcc_mmss_noc_cfg_ahb_clk" },
>   			.num_parents = 1,
> -			.flags = CLK_SET_RATE_PARENT,
> +			.flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL,
>   			.ops = &clk_branch2_ops,
>   		},
>   	},
> @@ -2903,7 +2903,7 @@ enum {
>   		.name = "mmagic_video",
>   	},
>   	.pwrsts = PWRSTS_OFF_ON,
> -	.flags = VOTABLE,
> +	.flags = VOTABLE | ALWAYS_ON,
>   };
>   
>   static struct gdsc mmagic_mdss_gdsc = {
> @@ -2913,7 +2913,7 @@ enum {
>   		.name = "mmagic_mdss",
>   	},
>   	.pwrsts = PWRSTS_OFF_ON,
> -	.flags = VOTABLE,
> +	.flags = VOTABLE | ALWAYS_ON,
>   };
>   
>   static struct gdsc mmagic_camss_gdsc = {
> @@ -2923,7 +2923,7 @@ enum {
>   		.name = "mmagic_camss",
>   	},
>   	.pwrsts = PWRSTS_OFF_ON,
> -	.flags = VOTABLE,
> +	.flags = VOTABLE | ALWAYS_ON,
>   };
>   
>   static struct gdsc venus_gdsc = {

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html