On Wed, 2017-11-15 at 11:58 +0530, Varadarajan Narayanan wrote:
> > + if (gpiochip->irq_need_valid_mask) {
> > + gpiochip->irq_valid_mask =
> > + kcalloc(BITS_TO_LONGS(gpiochip->ngpio),
> > + sizeof(long), GFP_KERNEL);
>
> Since 'irq_valid_mask' is getting filled below wouldn't a kmalloc
> suffice?
I suppose you meant kmalloc_array.
Anyway, it's a separate change if you wish, because Timur didn't change
the original approach here.
> > + if (!gpiochip->irq_valid_mask)
> > + return -ENOMEM;
> >
> > + /* Assume by default all GPIOs are valid */
> > + bitmap_fill(gpiochip->irq_valid_mask, gpiochip-
> > >ngpio);
> > + }
> >
> > + if (gpiochip->line_need_valid_mask) {
> > + gpiochip->line_valid_mask =
> > + kcalloc(BITS_TO_LONGS(gpiochip->ngpio),
> > + sizeof(long), GFP_KERNEL);
>
> Since 'line_valid_mask' is getting filled below wouldn't a kmalloc
> suffice?
This one just mimics previous, so, see above.
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
