On Tue, 2017-10-31 at 13:54 -0500, Timur Tabi wrote: > On 10/31/2017 04:12 AM, Andy Shevchenko wrote: > > Instead of mangling this function wouldn't be better to introduce a > > separate one for line and perhaps a third one which calls them both? > > The diff is convoluted, but the end result is clean: > Is this acceptable? I also put in the comment the following: --- 8< --- 8< --- 8< --- ...for my opinion it will drastically increase readability and reduce diff as well (better for review). --- 8< --- 8< --- 8< --- The decision is up to Linus. I simple shared my opinion. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
