On Wed, Oct 11, 2017 at 10:42:23AM +0100, Srinivas Kandagatla wrote: > On 11/10/17 05:07, Vinod Koul wrote: > >On Tue, Oct 10, 2017 at 06:21:34PM +0100, Srinivas Kandagatla wrote: > >>On 10/10/17 17:49, Vinod Koul wrote: > >>>>>>+/** > >>>>>>+ * slim_register_controller: Controller bring-up and registration. > >>... > >>>>>>+ > >>>>>>+ mutex_init(&ctrl->m_ctrl); > >>>>>>+ ret = device_register(&ctrl->dev); > >>>>> > >>>>>one more device_register?? Can you explain why > >>>>> > >>>> > >>>>This is a device for each controller. > >>> > >>>wont the controller have its own platform_device? > >> > >>Reason could be that slim_register controller can be called from any code > >>not just platform devices.. > > > >ah which cases would those be. I was expecting that you would have a > >platform_device as a slimbus controller which would call slim_register? > As of now there is only one controller which uses platform driver, but in > future there might be more, but this is something which makes the slimbus > core more flexible. even if you have more controllers wouldn't we have similar number of platform devices. Each instance of the link/controller would have its device node. Thanks -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
