On Tue 12 Sep 01:40 PDT 2017, Luca Weiss wrote: > This introduces the gpio-keys nodes for keys of the FP2 and the > associated pinctrl state. > > Signed-off-by: Luca Weiss <luca@xxxxxxxxx> > --- > arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts | 50 ++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts b/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts > index 79a5aa8b856a..4434c45086b8 100644 > --- a/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts > +++ b/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts > @@ -1,6 +1,10 @@ > #include "qcom-msm8974.dtsi" > #include "qcom-pm8841.dtsi" > #include "qcom-pm8941.dtsi" > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/input/input.h> > +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h> > + > > / { > model = "Fairphone 2"; > @@ -19,4 +23,50 @@ > serial@f991e000 { > status = "ok"; > }; > + > + gpio-keys { As this isn't a device on the "soc bus" (i.e. it doesn't have a reg=<>) it should not be child of &soc. Please move it to /, i.e. right after "choosen". Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html