During a kexec shutdown, machine_kexec_mask_interrupts() will attempt
to disable all IRQs that are registered. If gpio is not available,
don't register IRQs and it won't be in the irq_desc list it walks through.
If gpio is unavailable, perhaps a more correct fix that covers more is
to not calling gpiochip_irqchip_add() to register msm_gpio_irq_chip in
msm_gpio_init().
When registering interrupt for msm_qpio_irq_chip the following are
registered, not just irq_mask and irq_unmask.
static struct irq_chip msm_gpio_irq_chip = {
.name = "msmgpio",
.irq_mask = msm_gpio_irq_mask,
.irq_unmask = msm_gpio_irq_unmask,
.irq_ack = msm_gpio_irq_ack,
.irq_set_type = msm_gpio_irq_set_type,
.irq_set_wake = msm_gpio_irq_set_wake,
};
Technically the same check added in msm_gpio_irq_mask() and
msm_gpio_irq_unmask() should be added in msm_gpio_irq_ack(),
msm_gpio_irq_set_type(), and msm_gpio_irq_set_wake() if it's registered
with irq domain.
To cover more bases, the more correct way is to not register interrupt
with irq domain at all if gpio is unavailable.
On 08/09/2017 02:02 PM, Timur Tabi wrote:
On 07/31/2017 08:36 AM, Linus Walleij wrote:
To support sparse GPIO maps, pinctrl-msm client drivers can specify
that a given GPIO has a pin count of zero. These GPIOs will be
considered "hidden". Any attempt to claim the GPIO will fail, and they
will not be listed in debugfs.
During a kexec shutdown, machine_kexec_mask_interrupts() will attempt
to disable all IRQs, even those that aren't enabled. This includes
GPIOs that are unavailable (npins == 0), so add a check to the irq mask
and unmask functions.
Signed-off-by: Timur Tabi<timur@xxxxxxxxxxxxxx>
I'm waiting for Björn's review of the two remaining patches.
Björn, do you have time to review these patches? I'm hoping to get them
into 4.14.
--
Jiandi An
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a
Linux Foundation Collaborative Project.
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
