On Fri, May 26, 2017 at 8:56 AM, Robin Murphy <robin.murphy@xxxxxxx> wrote: >> + struct iommu_group *group; > > This feels weird, since a device can be associated with multiple > contexts, but only one group, so group-per-context is somewhat redundant > and smacks of being in the wrong place. Does the firmware ever map > multiple devices to the same context? so, actually it seems like I can dump all of this, and just plug generic_device_group directly in to iommu ops without needing to care about tracking the iommu_group myself. At least this appears to work. BR, -R -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html