Hi, On Mon, May 29, 2017 at 09:47:11PM -0700, Bjorn Andersson wrote: > On Mon 29 May 19:53 PDT 2017, Dmitry Torokhov wrote: > > > On Fri, May 26, 2017 at 11:51:30PM -0700, Bjorn Andersson wrote: > > > In some Qualcomm platforms the magic for informing LK which mode to > > > reboot into is stored in the PON_SOFT_RB_SPARE register. Register with > > > the reboot mode helpers to expose this to the user. > > > > Hmm, is the power key driver the best place to have this? WHy isn't this > > a driver in its own right? > > > > The functionality is part of the "PON" block in the Qualcomm PMICs, > other functionality from this block relates to configuration and > handling related to power-key and reset-key. > > Several of these properties are intermingled, so I do believe it's best > to handle them in a single driver; that said, it might no longer be > correct to name the driver "pwrkey" or that it is a "misc input" driver. I merged patch 1 and provided an immutable branch, so that this could go through the input subsystem. To me it doesn't look that intermingled, though. I think the reboot and reboot-mode parts could go into their own driver in drivers/power/reset. -- Sebastian
Attachment:
signature.asc
Description: PGP signature
