On Tue 16 May 11:00 PDT 2017, Jordan Crouse wrote: > diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c [..] > +#ifdef CONFIG_QCOM_MDT_LOADER Use #if IS_ENABLED(CONFIG_QCOM_MDT_LOADER) But this will be true even if the mdt-loader is compiled as a module and the adreno driver builtin, which would cause a link error. So in addition you need to add the following to your Kconfig: depends on QCOM_MDT_LOADER || QCOM_MDT_LOADER=n This will make sure that if the mdt-loader is "m" this driver has to be "m" (i.e. it will still link), but if the mdt-loader is "n" we can still compile this driver, but the #if in the code will be false. Apart from this: Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html