On 4/13/2017 4:51 PM, Bjorn Helgaas wrote: > I think these can go in drivers/pci/pci.h instead of the public > include/linux/pci.h. There's no ASPM section in drivers/pci/pci.h > yet, but I think we should add one. > > It looks like the following things from include/linux/pci-aspm.h could > be moved there as well, since they're only used by the PCI core: > > void pcie_aspm_init_link_state(struct pci_dev *pdev); > void pcie_aspm_exit_link_state(struct pci_dev *pdev); > void pcie_aspm_pm_state_change(struct pci_dev *pdev); > void pcie_aspm_powersave_config_link(struct pci_dev *pdev); > void pcie_aspm_create_sysfs_dev_files(struct pci_dev *pdev); > void pcie_aspm_remove_sysfs_dev_files(struct pci_dev *pdev); > > This would be a separate patch. > Sure, let me work on this. >> #else >> static inline bool pcie_aspm_support_enabled(void) { return false; } >> +static inline int pci_aspm_init(struct pci_dev *pdev) { return -ENODEV; } >> #endif -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html