On Wed, Mar 29, 2017 at 2:59 AM, Rob Herring <robh@xxxxxxxxxx> wrote: > On Wed, Mar 22, 2017 at 09:18:42AM +0100, Linus Walleij wrote: >> The concept of "active" clocks is just explained in a bried comment in the >> device driver, let's explain it a bit more in the device tree bindings >> so everyone understands this. >> >> Cc: devicetree@xxxxxxxxxxxxxxx >> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/clock/qcom,rpmcc.txt | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt >> index d470a0187035..cf80a00b7ff2 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt >> +++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt >> @@ -18,6 +18,14 @@ Required properties : >> >> - #clock-cells : shall contain 1 >> >> +The clock enumerators are defined in <dt-bindings/clock/qcom,rpmcc.h> >> +and come in pairs: FOO_CLK followed by FOO_A_CLK. The latter clock >> +is an "active" clock, which means that the consumer only care that the >> +clock is available when the system is active, i.e. not suspended. If >> +it is important that the clock keeps running during system suspend, >> +you need to specify the non-active clock, the one not containing >> +*_A_* in the enumerator name. >> + > > Sounds like abuse as the clock id is encoding policy into it. The number > of clocks should be the number of inputs to a block. I wouldn't be > opposed to some flags for clocks, but that should be a separate cell. I'm sorry about that, but I'm just documenting what is already a fact and was previously just implicit in the name. I first had no idea what this *_A_* infix notation was about so after some reading I found a comment in the driver saying this. I guess Stephen can confirm and/or elaborate on this. Keeping them around is I guess the lesser evil (as compard to pulling up the deployed bindings with the roots) at this point. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
