On Thu, Feb 16, 2017 at 7:00 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > We're off by one here. We free something that wasn't allocated and we > don't free msm_host->bus_clks[]. > > Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Thanks Reviewed-by: Rob Clark <robdclark@xxxxxxxxx> > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c > index 1fc07ce24686..4fa32296162e 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -437,7 +437,7 @@ static int dsi_bus_clk_enable(struct msm_dsi_host *msm_host) > > return 0; > err: > - for (; i > 0; i--) > + while (i--) > clk_disable_unprepare(msm_host->bus_clks[i]); > > return ret; -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html