[bug report] remoteproc: qcom: mdt_loader: Refactor MDT loader

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Bjorn Andersson,

The patch 7f0dd07a9b29: "remoteproc: qcom: mdt_loader: Refactor MDT
loader" from Jan 27, 2017, leads to the following static checker
warning:

	drivers/soc/qcom/mdt_loader.c:171 qcom_mdt_load()
	warn: unsigned 'offset' is never less than zero.

drivers/soc/qcom/mdt_loader.c
   164          for (i = 0; i < ehdr->e_phnum; i++) {
   165                  phdr = &phdrs[i];
   166  
   167                  if (!mdt_phdr_valid(phdr))
   168                          continue;
   169  
   170                  offset = phdr->p_paddr - mem_reloc;
   171                  if (offset < 0 || offset + phdr->p_memsz > mem_size) {
                            ^^^^^^^^^^
offset is size_t.

   172                          dev_err(dev, "segment outside memory range\n");
   173                          ret = -EINVAL;
   174                          break;
   175                  }
   176  

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux