Re: [PATCH 2/2] nvmem: core: Allow getting nvmem cell with a NULL cell id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/06, Vivek Gautam wrote:
> The nvmem cell with a NULL cell name/id should be the one
> with no accompanying 'nvmem-cell-names' property, and thus
> will be the cell at index 0 in the device tree.
> So, we default to index 0 and update the cell index only when
> nvmem cell name id exists.
> 
> Suggested-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> Signed-off-by: Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx>

Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>

Except the typo below:

> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 294cdef96277..d243dc6ad1a4 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -747,7 +747,9 @@ static struct nvmem_cell *nvmem_cell_get_from_list(const char *cell_id)
>   * of_nvmem_cell_get() - Get a nvmem cell from given device node and cell id
>   *
>   * @np: Device tree node that uses the nvmem cell.
> - * @name: nvmem cell name from nvmem-cell-names property.
> + * @name: nvmem cell name from nvmem-cell-names property, or NULL
> + *	  for the cell at index 0 (the lone cell with no acoompanying

s/acoompanying/accompanying/

> + *	  nvmem-cell-names property).
>   *
>   * Return: Will be an ERR_PTR() on error or a valid pointer
>   * to a struct nvmem_cell.  The nvmem_cell will be freed by the

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux