On 12/18, Imran Khan wrote: > > I had discussed this with Bjorn and it was recommended to keep it out of > smem.h. If needed I can move it back there. Ok no worries from me then if this has already been discussed. > > Yes. The numbers used here can have different meaning for different ODMs. > But these attributes (hw_patform type/subtype etc.) are outside the > generic soc_device_attribute so I think the interpretation of these numbers > can very well be ODM specific. We can try to keep only those types here that > are relevant for newer platforms but we intend to keep these attributes > nonetheless. I'll wait to see what the next patch version has. We will probably need to have some way to know which ODM the kernel is running on, so we can interpret the platform type/subtype fields properly. That part seems to be lacking from this patch right now. We assume it's always qcom as the ODM, which isn't true. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
