On 11/29, Avaneesh Kumar Dwivedi wrote: > This patch is based on > https://patchwork.kernel.org/patch/9415627/ > https://patchwork.kernel.org/patch/9415651/ > > This patch add clock initialization, enable and disable support. > Required resource name string and rating are differentiated based > on compatible string. Also added documentation for venus pil on > msm8996. > > Signed-off-by: Avaneesh Kumar Dwivedi <akdwived@xxxxxxxxxxxxxx> > --- > .../devicetree/bindings/remoteproc/qcom,venus.txt | 26 ++++- > drivers/remoteproc/qcom_venus_pil.c | 116 ++++++++++++++++++++- > 2 files changed, 140 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt b/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt > index 2d73ba1..417026b 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt > @@ -6,13 +6,30 @@ on the Qualcomm Venus remote processor core. > - compatible: > Usage: required > Value type: <string> > - Definition: must contain "qcom,venus-pil" > + Definition: must contain "qcom,venus-pil" or > + "qcom,venus-msm8996-pil" > > - memory-region: > Usage: required > Value type: <phandle> > Definition: a phandle to a node describing reserved memory > > +- clocks: > + Usage: required > + Value type: <prop-encoded-array> > + Definition: reference to the core, iface and bus and maxi clocks to be held on > + behalf of the booting of the venus core > + > +- clock-names: > + Usage: required > + Value type: <stringlist> > + Definition: should be "core_clk", "iface_clk", "bus_clk", "maxi_clk" Please drop _clk from all clock names. > + > +- power-domains: > + Usage: required > + Value type: <prop-encoded-array> > + Definition: reference to the venus gdsc to be turned on before booting venus core All these new properties can't be required if the original compatible is used, right? > + > * An example > reserved-memory { > #address-cells = <2>; > @@ -29,5 +46,12 @@ on the Qualcomm Venus remote processor core. > > rproc_venus@0 { > compatible = "qcom,venus-pil"; > + clocks = <&mmcc VIDEO_CORE_CLK>, > + <&mmcc VIDEO_AHB_CLK>, > + <&mmcc VIDEO_AXI_CLK>, > + <&mmcc VIDEO_MAXI_CLK>; > + > + clock-names = "core_clk", "iface_clk", "bus_clk", "maxi_clk"; > + power-domains = <&mmcc VENUS_GDSC>; > memory-region = <&venus_mem>; > }; -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
