On 11/29/2016 7:06 AM, Stephen Boyd wrote:
On 11/25, Avaneesh Kumar Dwivedi wrote:
This patch is based on
https://patchwork.kernel.org/patch/9415627/
https://patchwork.kernel.org/patch/9415651/
This patch add clock initialization, enable and disable support.
Required resource name string and rating are differentiated based
on compatible string. Also added documentation for venus pil on
msm8996.
Signed-off-by: Avaneesh Kumar Dwivedi <akdwived@xxxxxxxxxxxxxx>
---
Why isn't Stan Cced on this patch?
my bad will resend patch with Stan in CC
.../devicetree/bindings/remoteproc/qcom,venus.txt | 3 +-
drivers/remoteproc/qcom_venus_pil.c | 115 ++++++++++++++++++++-
2 files changed, 116 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt b/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt
index 2d73ba1..c986f52 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt
@@ -6,7 +6,8 @@ on the Qualcomm Venus remote processor core.
- compatible:
Usage: required
Value type: <string>
- Definition: must contain "qcom,venus-pil"
+ Definition: must contain "qcom,venus-pil" or
+ "qcom,venus-8996-pil"
- memory-region:
Usage: required
No addition of clocks or clock-names properties in this document?
Ok, Yes will do it.
diff --git a/drivers/remoteproc/qcom_venus_pil.c b/drivers/remoteproc/qcom_venus_pil.c
index 6d4e55b..23b7e99 100644
--- a/drivers/remoteproc/qcom_venus_pil.c
+++ b/drivers/remoteproc/qcom_venus_pil.c
@@ -194,8 +296,19 @@ static int venus_remove(struct platform_device *pdev)
return 0;
}
+static const struct venus_rproc_res venus_8996_res = {
+ .venus_clks = (char*[]){"mx", "cx", "pll", NULL},
+ .venus_clk_rate = {19200000, 19200000, 19200000, 80000000},
I'm very much lost. I don't really understand why we're adding
clock control here. Perhaps that is the responsibility of the
video driver itself and isn't supposed to be in the remoteproc
portion? Testing things standalone without the video driver seems
like a unit test, which is not too useful of a test if it doesn't
mirror real use cases.
There was a discussion with Bjorn<bjorn.andersson@xxxxxxxxxx>, where he
mention
"It only works if some other driver (the venus v4l driver) has enabled
a set of clocks and the gdsc. I do not like the concept of having a
driver that depends on the state of another driver to success..."
That is why this patch to handle clock resources within venus loader. As
far as gdsc is concerned, change to enable gdsc lies only in DT Node
where one need to define power-domain property. let me know if i have
misunderstood Bjorn, then i can drop this patch.
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
