On Mon, Jun 27, 2016 at 3:22 PM, Ritesh Harjani <riteshh@xxxxxxxxxxxxxx> wrote: > This patch series refreshes the older patch series sent a > while ago by Asutosh Das[1]. > > Current set of patch series is only introducing the basic CMDQ > driver to get more review comments. Based on the reviews, will > add other features as well to the patch list. kthread is deprecated since the talks of the last kernel summit. You should prefer to use workqueues. The queueing mechanism looks like a duplicate copy/paste solution built on the "old" processing queue. Overall this is the problem with the whole patch set: instead of a "deep" integration by improving the existing request processing, a separate code path is bolted on the side. What you should do is improve the existing infrastructure to accomodate for the new mechanism. For example: a new processing thread is introduced instead of augmenting the existing one to handle this case, resulting in a big slew of duplicated code. For example: this is not at all integrated with the other feature, packed command, which is *also* speculatively pulling out ever more stuff from the block layer, albeit in a totally different manner, actually integrated with the existing queue mechanism. Needless to say: these two features (packed command and command queue) should use the *same codepath* just that the command queuing is more powerful, so that packed command is merely a subset of the command queueing. Now: note that I sent a patch do delete packed command. I do not know if that will be accepted, but something deeply integrated is for sure needed, we need a elegant and compact core of code to maintain, not more copies of the already existing messy code. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
