On 11/09/2016 05:49 PM, Stephen Boyd wrote:
On 11/03, Sarangdhar Joshi wrote:
When devm_clk_get fails for core clock, the failure was ignored
and the core_clk was explicitly set to NULL so that other
remaining clocks can be queried. However, now that we have a
cleaner way of expressing the clock dependency, return failure
when devm_clk_get fails for core clock.
Signed-off-by: Sarangdhar Joshi <spjoshi@xxxxxxxxxxxxxx>
Why can't this be folded into the second patch? It seems
incorrect to allow it to silently work in patch 2 even though
we've flagged that clk as a requirement and then change that
behavior here.
The idea was keep it separate so that if someone needs to keep earlier
behavior (of ignoring the core clock failure), then it would be easier
to just revert this commit and still use flag mechanism. Also convenient
with git bisect for finding offending commit. I don't mind squashing
this into patch 2 if we think that's better.
Regards,
Sarang
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
