Hello Hans, On Fri, Nov 11, 2016 at 8:49 AM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > Hi Stanimir, > > Overall it looks good. As you saw, I do have some comments but nothing major. > > One question: you use qcom as the directory name. How about using qualcomm? > > It's really not that much longer and a bit more obvious. > > Up to you, though. > It seems qcom is more consistent to the name used in most subsystems for Qualcomm: $ find -name *qcom ./arch/arm/mach-qcom ./arch/arm64/boot/dts/qcom ./Documentation/devicetree/bindings/soc/qcom ./sound/soc/qcom ./drivers/pinctrl/qcom ./drivers/soc/qcom ./drivers/clk/qcom $ find -name *qualcomm ./drivers/net/ethernet/qualcomm > Regards, > > Hans > Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html