On Mon, Oct 31, 2016 at 11:20 PM, Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> wrote: >> + interrupt-parent = <&pm8058_gpio>; >> + interrupts = <208 IRQ_TYPE_EDGE_FALLING>; > > To remove the need of resetting the interrupt-parent in each child you > can use the following form: > > interrupts-extended = <&pm8058_gpio 208 IRQ_TYPE_EDGE_FALLING>; > > But, if we correct the ssbi gpio driver then this would no longer be > interrupt 208 in this parent, right?. I believe that if you say > <&pmicintc 208 IRQ_TYPE_EDGE_FALLING> instead, which should work even > after we correct the gpio translation. Yes. It should be fixed everywhere but is not related to this patch. But I can do a two-patch series first fixing this and then adding the gyro+accelerometer on top referencing the MFD pmicintc as parent. > (Which probably means we need to get that redesigned, before we > introduce to many of these) What needs to happen is for the SSBI and SPMI GPIO to use a hierarchical irqdomain so their GPIO local line offset and hwirq are the same. Then we can reference the GPIO IRQ lines directly in a correct manner. You are not alone with this mess. A lot of hierarchical GPIOs are wrong. My fail as GPIO maintainer I guess, ouch. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html