Re: [PATCH v6 1/5] ASoC: codecs: Add msm8916-wcd analog codec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 20, 2016 at 03:20:45PM +0100, Srinivas Kandagatla wrote:

> +static int pm8916_wcd_analog_parse_dt(struct device *dev,
> +				       struct pm8916_wcd_analog_priv *priv)
> +{

> +	priv->mclk = devm_clk_get(dev, "mclk");
> +	if (IS_ERR(priv->mclk)) {
> +		dev_err(dev, "failed to get mclk\n");
> +		return PTR_ERR(priv->mclk);
> +	}
> +	for (i = 0; i < ARRAY_SIZE(supply_names); i++)
> +		priv->supplies[i].supply = supply_names[i];
> +
> +	ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(priv->supplies),
> +				    priv->supplies);

The above isn't parsing the DT, it's just requesting resources - how
those resources are mapped is hidden behind the clock and regulator
APIs.  Please send a followup fixing this.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux