Re: [PATCH v4 3/9] mmc: sdhci-msm: add pltfm_data support to get clk-rates from DT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arnd,

On 9/12/2016 1:03 PM, Arnd Bergmann wrote:
On Wednesday, August 24, 2016 3:33:38 PM CEST Ritesh Harjani wrote:
 #define CMUX_SHIFT_PHASE_SHIFT 24
 #define CMUX_SHIFT_PHASE_MASK  (7 << CMUX_SHIFT_PHASE_SHIFT)

+struct sdhci_msm_pltfm_data {
+       u32 *clk_table;
+       int clk_table_sz;
+};
+
 struct sdhci_msm_host {
        struct platform_device *pdev;
        void __iomem *core_mem; /* MSM SDCC mapped address */
@@ -83,6 +88,7 @@ struct sdhci_msm_host {
        struct clk *bus_clk;    /* SDHC bus voter clock */
        struct mmc_host *mmc;
        bool use_14lpp_dll_reset;
+       struct sdhci_msm_pltfm_data *pdata;
 };

 /* Platform specific tuning */


Just noticed this. Please don't add another structure, just put the
new members into struct sdhci_msm_host directly.

We only need platform_data structures for drivers that also work
with old-style board files, which this one doesn't.

Ok, I will move this into sdhci_msm_host directly.


Thanks
Ritesh


	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux