On 19/03/2025 15:36, srinivas.kandagatla@xxxxxxxxxx wrote: > From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> > > This patch adds sound support for this platform, > support includes > - 2x Speakers. > - 2x dmic > - Headset > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> > --- > > This patch depends on > "arm64: dts: qcom: Add device tree for TUXEDO Elite 14 Gen1" patch > https://lkml.org/lkml/2025/3/6/867 > > ucm changes: > https://github.com/Srinivas-Kandagatla/alsa-ucm-conf/tree/x1e80100-tuxedo > > tplg changes: > https://github.com/Srinivas-Kandagatla/audioreach-topology/tree/tuxedo-elite-14 > > .../qcom/x1e80100-tuxedo-elite-14-gen1.dts | 190 ++++++++++++++++++ > 1 file changed, 190 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-tuxedo-elite-14-gen1.dts b/arch/arm64/boot/dts/qcom/x1e80100-tuxedo-elite-14-gen1.dts > index 86bdec4a2dd8..465221b8a3fa 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100-tuxedo-elite-14-gen1.dts > +++ b/arch/arm64/boot/dts/qcom/x1e80100-tuxedo-elite-14-gen1.dts > @@ -20,6 +20,34 @@ aliases { > serial0 = &uart21; > }; > > + No need for blank line > + wcd938x: audio-codec { > + compatible = "qcom,wcd9385-codec"; > + > + pinctrl-0 = <&wcd_default>; > + pinctrl-names = "default"; > + > + qcom,micbias1-microvolt = <1800000>; > + qcom,micbias2-microvolt = <1800000>; > + qcom,micbias3-microvolt = <1800000>; > + qcom,micbias4-microvolt = <1800000>; > + qcom,mbhc-buttons-vthreshold-microvolt = <75000 150000 237000 500000 500000 500000 500000 500000>; > + qcom,mbhc-headset-vthreshold-microvolt = <1700000>; > + qcom,mbhc-headphone-vthreshold-microvolt = <50000>; > + qcom,rx-device = <&wcd_rx>; > + qcom,tx-device = <&wcd_tx>; > + > + reset-gpios = <&tlmm 191 GPIO_ACTIVE_LOW>; > + > + vdd-buck-supply = <&vreg_l15b_1p8>; > + vdd-rxtx-supply = <&vreg_l15b_1p8>; > + vdd-io-supply = <&vreg_l15b_1p8>; > + vdd-mic-bias-supply = <&vreg_bob1>; > + > + Here only one as well > + #sound-dai-cells = <1>; > + }; > + ... > +&swr0 { > + status = "okay"; > + > + pinctrl-0 = <&wsa_swr_active>, <&spkr_01_sd_n_active>; > + pinctrl-names = "default"; > + > + /* WSA8845, Left Speaker */ > + left_spkr: speaker@0,0 { > + compatible = "sdw20217020400"; > + reg = <0 0>; > + reset-gpios = <&lpass_tlmm 12 GPIO_ACTIVE_LOW>; Interesting that on X1E even two-speaker configurations share the reset GPIO. Typical two-speaker setups like MTP and QRD use two different GPIOs. Assuming this is not a copy-paste and with blank line fixes: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
