On Wed, Mar 19, 2025 at 05:02:39PM +0530, Vasanthakumar Thiagarajan wrote: > > > On 3/19/2025 3:57 PM, Krzysztof Kozlowski wrote: > > On 19/03/2025 10:06, Vasanthakumar Thiagarajan wrote: > > > > > > --- > > > > > > base-commit: 7eb172143d5508b4da468ed59ee857c6e5e01da6 > > > > > > change-id: 20250303-topic-ath12k-fix-crash-49e9055c61a1 > > > > > > > > > > > > Best regards, > > > > > > > > > > NAK since this will break QCN > > > > > There is a series under internal review to address MLO issues for WCN chipsets > > > > > > > > ??? > > > > > > > > The original commit is wrong, this fixes the conversion, nothing else. > > > > > > Nope. Driver changes to enable MLO with WCN chipset are not there yet. > > > Setting the mlo capability flag without having required driver changes > > > for WCN chipset will likely result in firmware crash. So the recommendation > > > is to enable MLO (in WCN) only when all the necessary driver changes > > > (in development, public posting in near future) are in place. > > Really, these are your answers? There is regression and first reply is > > upstream should wait for whatever you do internally. Second answer is > > the same - public posting in near future? > > > > May be I was not clear in my response. I was not telling MLO bug fixes were > in the development. Actually the MLO feature itself is not enabled > yet with WCN chip sets. Any code changes enabling it without full feature > support would result in firmware crashes with the existing firmware binaries > available in upstream. Is there an undocumented change of the behaviour in the commit 46d16f7e1d14 ("wifi: ath12k: rename mlo_capable_flags to single_chip_mlo_supp")? -- With best wishes Dmitry