On Mon, Mar 10, 2025 at 02:30:59PM +0800, Ziyue Zhang wrote: > Add support for QCS8300 SoC that uses controller version 5.90 so reusing > the 1.34.0 config. This is not a valid argument. You should mention that the controller is of version <Qcom IP version>, but compatible with version 1.34.0 controllers and hence reusing that ops. 5.90 is the synopsys IP version, not Qcom one. You should mention both. > Please add more info about the controller like link speed, max lane count, etc... Moreover, cfg_1_34_0 has the 'override_no_snoop' bit set to override read/write no snoop attributes. Are they applicable to this controller also? - Mani -- மணிவண்ணன் சதாசிவம்
