On Thu, Mar 13, 2025 at 04:33:57PM +0530, Manikanta Mylavarapu wrote: > +static struct clk_rcg2 nss_cc_clc_clk_src = { > + .cmd_rcgr = 0x28604, > + .mnd_width = 0, > + .hid_width = 5, > + .parent_map = nss_cc_parent_map_6, > + .freq_tbl = ftbl_nss_cc_clc_clk_src, > + .clkr.hw.init = &(const struct clk_init_data) { > + .name = "nss_cc_clc_clk_src", > + .parent_data = nss_cc_parent_data_6, > + .num_parents = ARRAY_SIZE(nss_cc_parent_data_6), > + .ops = &clk_rcg2_ops, > + }, > +}; This structure definition gets repeated many times in this driver, with only slight changes. (This also happens in other qualcomm clock drivers.) Would it be possible to refactor it into a macro, to avoid the insane code repetition? Marek