Re: [PATCH 3/3] arm64: dts: qcom: sm8650: Add description of MCLK pins

["Bryan O'Donoghue" <bryan.odonoghue@xxxxxxxxxx>]

On 12/03/2025 00:11, Vladimir Zapolskiy wrote:
> Add fixed MCLK pin descriptions for all pins with such supported
> function.
>
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>
> ---
>   arch/arm64/boot/dts/qcom/sm8650.dtsi | 144 +++++++++++++++++++++++++++
>   1 file changed, 144 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> index bf5e238a93c3..526ef2ae8ac8 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> @@ -5792,6 +5792,150 @@ tlmm: pinctrl@f100000 {
>   
>   			wakeup-parent = <&pdc>;
>   
> +			cam0_default: cam0-default-state {
> +				mclk-pins {
> +					pins = "gpio100";
> +					function = "cam_mclk";
> +					drive-strength = <2>;
> +					bias-disable;
> +				};
> +			};
> +
> +			cam0_sleep: cam0-sleep-state {
> +				mclk-pins {
> +					pins = "gpio100";
> +					function = "cam_mclk";
> +					drive-strength = <2>;
> +					bias-pull-down;
> +				};
> +			};
> +
> +			cam1_default: cam1-default-state {
> +				mclk-pins {
> +					pins = "gpio101";
> +					function = "cam_mclk";
> +					drive-strength = <2>;
> +					bias-disable;
> +				};
> +			};
> +
> +			cam1_sleep: cam1-sleep-state {
> +				mclk-pins {
> +					pins = "gpio101";
> +					function = "cam_mclk";
> +					drive-strength = <2>;
> +					bias-pull-down;
> +				};
> +			};
> +
> +			cam2_default: cam2-default-state {
> +				mclk-pins {
> +					pins = "gpio102";
> +					function = "cam_aon_mclk2";
> +					drive-strength = <2>;
> +					bias-disable;
> +				};
> +			};
> +
> +			cam2_sleep: cam2-sleep-state {
> +				mclk-pins {
> +					pins = "gpio102";
> +					function = "cam_aon_mclk2";
> +					drive-strength = <2>;
> +					bias-pull-down;
> +				};
> +			};
> +
> +			cam3_default: cam3-default-state {
> +				mclk-pins {
> +					pins = "gpio103";
> +					function = "cam_mclk";
> +					drive-strength = <2>;
> +					bias-disable;
> +				};
> +			};
> +
> +			cam3_sleep: cam3-sleep-state {
> +				mclk-pins {
> +					pins = "gpio103";
> +					function = "cam_mclk";
> +					drive-strength = <2>;
> +					bias-pull-down;
> +				};
> +			};
> +
> +			cam4_default: cam4-default-state {
> +				mclk-pins {
> +					pins = "gpio104";
> +					function = "cam_aon_mclk4";
> +					drive-strength = <2>;
> +					bias-disable;
> +				};
> +			};
> +
> +			cam4_sleep: cam4-sleep-state {
> +				mclk-pins {
> +					pins = "gpio104";
> +					function = "cam_aon_mclk4";
> +					drive-strength = <2>;
> +					bias-pull-down;
> +				};
> +			};
> +
> +			cam5_default: cam5-default-state {
> +				mclk-pins {
> +					pins = "gpio105";
> +					function = "cam_mclk";
> +					drive-strength = <2>;
> +					bias-disable;
> +				};
> +			};
> +
> +			cam5_sleep: cam5-sleep-state {
> +				mclk-pins {
> +					pins = "gpio105";
> +					function = "cam_mclk";
> +					drive-strength = <2>;
> +					bias-pull-down;
> +				};
> +			};
> +
> +			cam6_default: cam6-default-state {
> +				mclk-pins {
> +					pins = "gpio108";
> +					function = "cam_mclk";
> +					drive-strength = <2>;
> +					bias-disable;
> +				};
> +			};
> +
> +			cam6_sleep: cam6-sleep-state {
> +				mclk-pins {
> +					pins = "gpio108";
> +					function = "cam_mclk";
> +					drive-strength = <2>;
> +					bias-pull-down;
> +				};
> +			};
> +
> +			cam7_default: cam7-default-state {
> +				mclk-pins {
> +					pins = "gpio106";
> +					function = "cam_mclk";
> +					drive-strength = <2>;
> +					bias-disable;
> +				};
> +			};
> +
> +			cam7_sleep: cam7-sleep-state {
> +				mclk-pins {
> +					pins = "gpio106";
> +					function = "cam_mclk";
> +					drive-strength = <2>;
> +					bias-pull-down;
> +				};
> +			};
> +
>   			cci0_0_default: cci0-0-default-state {
>   				sda-pins {
>   					pins = "gpio113";

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>