On 3/10/25 1:18 PM, Johan Hovold wrote: > On Sat, Mar 08, 2025 at 05:26:26PM +0100, Konrad Dybcio wrote: >> On 7.03.2025 6:10 PM, Johan Hovold wrote: >>> Add support for the keypad volume-up key on the debug extension board. >>> >>> This is useful to have when testing PMIC interrupt handling, and the key >>> can also be used to wake up from deep suspend states (CX shutdown). >>> >>> Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> >> >> I'm lukewarm about this since there is no "actual" button for that. > > There is certainly a physical button on the debug board. And the UEFI > firmware also supports it (e.g. it can be used in GRUB). > >> Does the power button not work here? > > For wake up, yes, but not for testing PMIC GPIO interrupts. > >> If systemd induces a shutdown, try setting >> >> HandlePowerKey=ignore >> >> in /etc/systemd/logind.conf > > I'm aware of that, but the volume key can be used without updating user > space (possibly also for CI testing if that signal can be controlled > remotely like the power button). Alright, I see Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> Konrad
