On 06/03/2025 12:52, Krzysztof Kozlowski wrote: > On 20/02/2025 10:42, Varadarajan Narayanan wrote: >> All DT entries except "reg" is similar between ipq5332 and ipq9574. ipq9574 >> has 5 registers while ipq5332 has 6. MHI is the additional (i.e. sixth >> entry). Since this matches with the sdx55's "reg" definition which allows >> for 5 or 6 registers, combine ipq9574 with sdx55. >> >> This change is to prepare ipq9574 to be used as ipq5332's fallback >> compatible. >> >> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Unreviewed. > >> Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx> >> --- >> v8: Add 'Reviewed-by: Krzysztof Kozlowski' >> --- >> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> index 7235d6554cfb..4b4927178abc 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> @@ -169,7 +169,6 @@ allOf: >> enum: >> - qcom,pcie-ipq6018 >> - qcom,pcie-ipq8074-gen3 >> - - qcom,pcie-ipq9574 > > Why you did not explain that you are going to affect users of DTS? > > NAK I did not connect the dots, but I pointed out that you break users and your DTS is wrong: https://lore.kernel.org/all/f7551daa-cce5-47b3-873f-21b9c5026ed2@xxxxxxxxxx/ so you should come back with questions to clarify what to do, not keep pushing this incorrect patchset. My bad, I should really have zero trust. Best regards, Krzysztof
