Re: [PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for tx_status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/30/2016 1:04 PM, Vinod Koul wrote:
> On Tue, Aug 23, 2016 at 12:48:11AM -0400, Sinan Kaya wrote:
> 
>>  	spin_lock_init(&lldev->lock);
>> -	tasklet_init(&lldev->rst_task, hidma_ll_abort, (unsigned long)lldev);
> 
> ??
> 
> This is not described in changlog? If you are not using in anywhere else,
> then rst_task variable should be removed too..
> 

Sure, I can add more description. I thought I did mention that we are no longer
resetting the hardware in ISR. 

I can certainly mention that rst_task variable is removed and can get rid of it.
It is no longer in use.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux