On 4.03.2025 10:46 AM, Dmitry Baryshkov wrote: > On Tue, 4 Mar 2025 at 10:33, Sricharan Ramabadhran > <quic_srichara@xxxxxxxxxxx> wrote: >> >> >> >> On 3/3/2025 6:34 PM, Dmitry Baryshkov wrote: >>> On Mon, Mar 03, 2025 at 03:58:42PM +0530, Sricharan Ramabadhran wrote: >>>> >>>> >>>> On 2/28/2025 12:03 PM, Dmitry Baryshkov wrote: >>>>> On Fri, Feb 28, 2025 at 10:23:56AM +0530, Sricharan R wrote: >>> >>>>>> + dev_err(dev, "Failed with status: %d\n", msg.resp.status); >>>>>> + ret = msg.resp.status; >>>>> >>>>> return msg.resp.status (is it really errno?) >>>>> >>>> ok, yes error. >>> >>> The question was if it is an errno, not if it is an error. >> status != 0 is an error always. > > Is it an _errno_ ? Dmitry's asking whether the status conforms to the Linux's errno.h ABI. If not, add something like: ret = msg.resp.status ? -EINVAL : 0 Konrad
