Re: [PATCH 2/4 v2] soc: qcom: add EBI2 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 29 August 2016, Linus Walleij wrote:
> >> +static struct platform_driver qcom_ebi2_driver = {
> >> +     .probe = qcom_ebi2_probe,
> >> +     .driver = {
> >> +             .name = "qcom-ebi2",
> >> +             .of_match_table = qcom_ebi2_of_match,
> >> +     },
> >> +};
> >> +builtin_platform_driver(qcom_ebi2_driver);
> >
> > Why not allow this to be a loadable module?
> 
> I don't see any point in it, it's so basic to be able to access the
> MMIO devices on the platform, the plan was to select the driver
> from the corresponding mach-qcom SoC type (MSM8660+APQ8060).
> 
> But I can make it a module instead, if preferred.

Ok, I expected this to be only for rare optional devices such as
NOR flash or the ethernet device from your example. If this is required
for booting a system, making it a module won't help much.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux