On Thu, Feb 27, 2025 at 09:27:47AM +0530, Manivannan Sadhasivam wrote: > On Tue, Feb 25, 2025 at 03:03:57PM +0530, Krishna Chaitanya Chundru wrote: > > TC956x is the PCIe switch which has one upstream and three downstream > > ports. To one of the downstream ports ethernet MAC is connected as endpoint > > device. Other two downstream ports are supposed to connect to external > > device. One Host can connect to TC956x by upstream port. > > > > TC956x switch power is controlled by the GPIO's. After powering on > > the switch will immediately participate in the link training. if the > > host is also ready by that time PCIe link will established. > > > > The TC956x needs to configured certain parameters like de-emphasis, > > disable unused port etc before link is established. > > > > As the controller starts link training before the probe of pwrctl driver, > > the PCIe link may come up as soon as we power on the switch. Due to this > > configuring the switch itself through i2c will not have any effect as > > this configuration needs to done before link training. To avoid this > > introduce two functions in pci_ops to start_link() & stop_link() which > > will disable the link training if the PCIe link is not up yet. > > > > Enable global IRQ for PCIe controller so that recan can happen when > > link was up through global IRQ. > > > > Move these patches to a separate series. > Or you can just drop them. I have a series that adds global IRQ to most of the SoCs and sc7280 is one of them. - Mani -- மணிவண்ணன் சதாசிவம்