Hi Jonathan, On 2/1/2025 5:03 PM, Jonathan Cameron wrote: > On Sat, 1 Feb 2025 00:02:40 +0530 > Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx> wrote: > >> For the PMIC5-Gen3 type PMICs, ADC peripheral is present in HW for the >> following PMICs: PMK8550, PM8550, PM8550B and PM8550VX PMICs. >> >> It is similar to PMIC5-Gen2, with SW communication to ADCs on all PMICs >> going through PBS(Programmable Boot Sequence) firmware through a single >> register interface. This interface is implemented on SDAM (Shared >> Direct Access Memory) peripherals on the master PMIC PMK8550 rather >> than a dedicated ADC peripheral. >> >> Add documentation for PMIC5 Gen3 ADC and macro definitions for ADC >> channels and virtual channels (combination of ADC channel number and >> PMIC SID number) per PMIC, to be used by clients of this device. > > A few really minor comments inline given you are going to be doing a v6 > for the build errors Rob's bot found. I guess this is racing > with some other changes. > I'll address all your comments in the next patch series. Thanks, Jishnu >> >> Signed-off-by: Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx> >> ---
