On 25/02/2025 13:18, Ayushi Makhija wrote:
> + pinctrl-0 = <&dsi0_int_pin>,
> + <&dsi0_cbl_det_pin>,
> + <&dsi1_int_pin>,
> + <&dsi1_cbl_det_pin>;
> + pinctrl-names = "default";
> +
> + dsi0_int_pin: gpio2_cfg {
No underscores, see DTS coding style.
> + pins = "gpio2";
> + input-enable;
> + bias-disable;
> + };
> +
> + dsi0_cbl_det_pin: gpio3_cfg {
> + pins = "gpio3";
> + bias-pull-down;
> + };
> +
> + dsi1_int_pin: gpio10_cfg {
> + pins = "gpio10";
> + input-enable;
> + bias-disable;
> + };
> +
> + dsi1_cbl_det_pin: gpio11_cfg {
> + pins = "gpio11";
> + bias-pull-down;
> + };
> + };
> +
> + i2c-mux@70 {
> + compatible = "nxp,pca9543";
> + #address-cells = <1>;
> +
> + #size-cells = <0>;
> + reg = <0x70>;
> +
> + i2c@0 {
> + reg = <0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + anx_bridge_1: anx7625@58 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "analogix,anx7625";
> + reg = <0x58>;
> + interrupt-parent = <&io_expander>;
> + interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
> + enable-gpios = <&io_expander 1 0>;
> + reset-gpios = <&io_expander 0 0>;
Use proper defines.
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + dsi2dp_bridge_1_in: port@0 {
> + reg = <0>;
> +
> + anx7625_1_in: endpoint {
> + remote-endpoint = <&mdss0_dsi0_out>;
> + };
> + };
> +
> + dsi2dp_bridge_1_out: port@1 {
> + reg = <1>;
> +
> + anx7625_1_out: endpoint { };
> + };
> + };
> + };
> + };
> +
> + i2c@1 {
> + reg = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + anx_bridge_2: anx7625@58 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "analogix,anx7625";
> + reg = <0x58>;
> + interrupt-parent = <&io_expander>;
> + interrupts = <10 IRQ_TYPE_EDGE_FALLING>;
> + enable-gpios = <&io_expander 9 0>;
> + reset-gpios = <&io_expander 8 0>;
Best regards,
Krzysztof
