On Mon, Feb 24, 2025 at 02:38:24PM +0530, Manikanta Mylavarapu wrote:
>
>
> On 2/24/2025 11:42 AM, George Moussalem wrote:
> > From: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
> >
> > In IPQ5018, Tsens IP doesn't have RPM. Hence the early init to
> > enable tsens would not be done. So add a flag for that in feat
> > and skip enable checks. Without this, tsens probe fails.
> >
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
> > Signed-off-by: George Moussalem <george.moussalem@xxxxxxxxxxx>
> > ---
> > drivers/thermal/qcom/tsens.c | 2 +-
> > drivers/thermal/qcom/tsens.h | 3 +++
> > 2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
> > index 3aa3736181aa..a25ca17adf1a 100644
> > --- a/drivers/thermal/qcom/tsens.c
> > +++ b/drivers/thermal/qcom/tsens.c
> > @@ -975,7 +975,7 @@ int __init init_common(struct tsens_priv *priv)
> > ret = regmap_field_read(priv->rf[TSENS_EN], &enabled);
> > if (ret)
> > goto err_put_device;
> > - if (!enabled) {
> > + if (!enabled && !(priv->feat->ignore_enable)) {
>
> Please drop 'ignore_enable' and use 'VER_2_X_NO_RPM' instead.
It is not possible, since IPQ5018 is 1.x. But I agree, a similar concept
should be used.
>
> > dev_err(dev, "%s: device not enabled\n", __func__);
> > ret = -ENODEV;
> > goto err_put_device;
--
With best wishes
Dmitry
