On Fri, Feb 14, 2025 at 03:17:46PM +0530, Vikram Sharma wrote: > +properties: > + compatible: > + const: qcom,qcs8300-camss > + > + reg: > + maxItems: 21 > + > + reg-names: > + items: > + - const: csid_wrapper Why different order of entries than sm8550? > + - const: csid0 > + - const: csid1 > + - const: csid_lite0 > + - const: csid_lite1 > + - const: csid_lite2 > + - const: csid_lite3 > + - const: csid_lite4 > + - const: csiphy0 > + - const: csiphy1 > + - const: csiphy2 > + - const: tpg0 > + - const: tpg1 > + - const: tpg2 > + - const: vfe0 > + - const: vfe1 > + - const: vfe_lite0 > + - const: vfe_lite1 > + - const: vfe_lite2 > + - const: vfe_lite3 > + - const: vfe_lite4 > + > + clocks: > + maxItems: 26 > + > + clock-names: > + items: > + - const: camnoc_axi > + - const: core_ahb > + - const: cpas_ahb > + - const: cpas_fast_ahb_clk > + - const: cpas_ife_lite > + - const: cpas_vfe0 > + - const: cpas_vfe1 > + - const: csid > + - const: csiphy0 > + - const: csiphy0_timer > + - const: csiphy1 > + - const: csiphy1_timer > + - const: csiphy2 > + - const: csiphy2_timer > + - const: csiphy_rx > + - const: gcc_axi_hf > + - const: gcc_axi_sf > + - const: icp_ahb > + - const: vfe0 > + - const: vfe0_fast_ahb > + - const: vfe1 > + - const: vfe1_fast_ahb > + - const: vfe_lite > + - const: vfe_lite_ahb > + - const: vfe_lite_cphy_rx > + - const: vfe_lite_csid > + > + interrupts: > + maxItems: 20 > + > + interrupt-names: > + items: > + - const: csid0 > + - const: csid1 > + - const: csid-lite0 > + - const: csid-lite1 > + - const: csid-lite2 > + - const: csid-lite3 > + - const: csid-lite4 Different naming than existing variants. Keep it consistent. > + - const: csiphy0 > + - const: csiphy1 > + - const: csiphy2 > + - const: tpg0 > + - const: tpg1 > + - const: tpg2 > + - const: vfe0 > + - const: vfe1 > + - const: vfe-lite0 > + - const: vfe-lite1 > + - const: vfe-lite2 > + - const: vfe-lite3 > + - const: vfe-lite4 Best regards, Krzysztof
