On 20.02.2025 9:49 AM, Krzysztof Kozlowski wrote: > Add LPASS macro codecs and LPASS TLMM pin controller on Qualcomm SM8750 > for proper sound support. These are fully compatible with earlier SM8550. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > --- [...] > + lpass_vamacro: codec@7660000 { > + compatible = "qcom,sm8750-lpass-va-macro", "qcom,sm8550-lpass-va-macro"; > + reg = <0x0 0x07660000 0x0 0x1000>; The VA macro is 0x2000-long instead > + clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > + <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > + <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>; > + clock-names = "mclk", > + "macro", > + "dcodec"; > + > + #clock-cells = <0>; > + clock-output-names = "fsgen"; > + #sound-dai-cells = <1>; > + }; > + Looks reasonable otherwise Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> Konrad