On Thu, Feb 20, 2025 at 07:42:29PM +0200, Abel Vesa wrote: > Since the driver and dt-bindings have been alread merged, it has been > agreed offline that there is no point of holding on to these DT patches > even though there are some issues with plug/unplug during suspend in > both pmic-glink-altmode and ucsi-glink. These issues are being worked on > meanwhile. Merging these means that even though this will provide external DP > and USB orientation, plug/unplug during suspend will give some splats > and render both the USB orientation and DP broken. But then, other > X Elite boards already have these nodes described, so lets bring the crd > and t14s to the same level. > > These patches are just a resend of the ones found in v5 and dropped in the v6 > patchset of the driver and dt-bindings. > > Link to v5: https://lore.kernel.org/all/20241112-x1e80100-ps8830-v5-0-4ad83af4d162@xxxxxxxxxx/ > > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx> > --- > Abel Vesa (4): > arm64: dts: qcom: x1e80100-crd: Describe the Parade PS8830 retimers > arm64: dts: qcom: x1e80100-crd: Enable external DisplayPort support > arm64: dts: qcom: x1e80100-t14s: Describe the Parade PS8830 retimers > arm64: dts: qcom: x1e80100-t14s: Enable external DisplayPort support It looks like you've addressed all the comments I had on v1 (except for a stray newline after a t14s port@2 node) and I've been running with these patches for a long time now without any issues (other than the glink hotplug issues mentioned above): Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx> Tested-by: Johan Hovold <johan+linaro@xxxxxxxxxx> Johan
