On 21.02.2025 02:56, Andrew Lunn wrote: > On Wed, Feb 19, 2025 at 10:03:50PM +0100, Heiner Kallweit wrote: >> Move PHY package related inline functions from phy.h to phy_package.c. >> While doing so remove locked versions phy_package_read() and >> phy_package_write() which have no user. > > What combination of builtin and modules have you tried? Code like this > is often in the header because we get linker errors in some > configurations. It might be worth checking the versions of the > original patches from Christian to see if there was such issues. > The PHY package functions are used by PHY drivers only, all of them have a Kconfig dependency on PHYLIB. I don't see a scenario where we could have the problem you're mentioning. But right, the PHY package function declarations are a candidate for a new header file not to be used outside drivers/net/phy. > Andrew Heiner
