On Thu, Aug 18, 2016 at 2:07 PM, Lothar Waßmann <LW@xxxxxxxxxxxxxxxxxxx> wrote: >> +#define EBI2_CSN_MASK BIT(2)|BIT(3)|BIT(4)|BIT(5)|BIT(6)|BIT(7) >> + > missing '()' around expression, otherwise... > >> + csval &= ~EBI2_CSN_MASK; > ...this will be '~BIT(2) | BIT(3) | BIT(4) | BIT(5) | BIT(6) | BIT(7)' > which is most likely NOT what's intended. > > (Also spaces around the '|' operator would improve readability) Sorry for not mentioning in my latest v2 revision: I solved this by using GENMASK(0,9) (yeah it also turns out to be more than 8 bits of CS...) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
